Revert hard require on epel for CentOS 7 #998
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wyardley
force-pushed
the
wyardley/issues_995
branch
4 times, most recently
from
a190e52 to
c6928ad
Compare
This leaves some of the documentation about epel, and installs it for acceptance tests, but leaves it up to users on CentOS to include this separately if needed. Fixes voxpupuli#995
wyardley
force-pushed
the
wyardley/issues_995
branch
from
c6928ad to
98e60cf
Compare
|
@bastelfreak I'm guessing you'll like #997 better, but maybe this option is also worth considering -- despite making the tests a bit clunkier, it gets us closer to the original documented behavior and makes the actual module behavior more simple IMO. I'm good with either way (or open to other suggestions). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
This leaves some of the documentation about epel, and installs it for acceptance tests, but leaves it up to users on CentOS to include this separately if needed.
(continuation of #996)
This Pull Request (PR) fixes the following issues
Fixes #995
Closes #997